LucaCappelletti94 commented on PR #2592: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2592#issuecomment-5960015055
> So what is the next step here? WOuld you like me to try a PR in datafusion to see what this change would look like downstream? My expectation is that any generic-based approach refactoring (and I do not see other approaches that would not make it extremely tedious not being able to match & unpack downstream) would go hand-in-hand with the trait refactoring, but that is a large amount of work in itself. I would aim to explore this more in details sometimes in November, keeping for this month's target to complete the refactoring and close as many fuzzer gaps as possible before thinking as such extensive refactoring. > Do we have any raw parsing benchmarks here in this repo? Insufficient in my opinion for any generalizable claims. We need to prepare a suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
