adriangb commented on PR #25771:
URL: https://github.com/apache/datafusion/pull/25771#issuecomment-5958710781
Then you benchmarks look great! The standard benchmarks look like they have
some small wins too, or are at least not regressions.
> all_false: yes, that's a real regression. when the first conjunct already
rules out every row, main returns right away, while this pr first flattens the
chain of conjuncts before it can stop (about 40 to 50 ns per batch). i'll
remove that and post numbers.
OK will wait for you to push this change and we can rerun!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]