zhangfengcdt commented on issue #5643:
URL:
https://github.com/apache/datafusion-comet/issues/5643#issuecomment-5956872835
The following is a new checklist introduced and addressed by #6138.
- [ ] identity partition on a `float` or `double` column, including a nested
one. Pending apache/iceberg-rust#3325 and its fix apache/iceberg-rust#3327: the
rule `requireNoFloatingPointPartitionField` can be removed once the
iceberg-rust pin carries that fix. When it is removed, the two
`assertNativeWriteDoesNotEngage` calls in`CometIcebergWriteActionSuite`
("signed-zero float and double identity partitions match iceberg-java" and
"float and double partition paths match iceberg-java") should go back to
`assertNativeWriteEngages`.
@andygrove Please feel free to add this to the restriction list above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
