andygrove commented on PR #6076: URL: https://github.com/apache/datafusion-comet/pull/6076#issuecomment-5950401917
#6451 is now on `main`. It marks the five `regr_*` serdes `Incompatible` until the merge matches Spark, which is exactly what this PR does. With it merged in, three of your tests fail because the `regr_*` queries fall back to Spark. `statistical aggregates with large nearby values` and `statistical aggregates merge large nearby values across partitions` find 0 Comet aggregates instead of 2, and `statistical aggregates merge fractional constants across partitions` reports the #6423 fallback reason. Could you lift that marking in this PR? That means removing the `getSupportLevel` and `getIncompatibleReasons` overrides from `CometRegrBase` in `aggregates.scala`, restoring the six `regr_*` rows in `expressions.md`, dropping the five `allowIncompatible` lines from `regr.sql`, and deleting `regr_fallback.sql`. Your fractional-constants test already covers that data with two partitions asserted. The description can then say this PR is the real fix for #6423 and replaces #6451's fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
