alamb commented on code in PR #25275: URL: https://github.com/apache/datafusion/pull/25275#discussion_r4158545322
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -1192,6 +1192,17 @@ DROP TABLE distinct_pct_nulls; # percentile_cont for shorter floats +# Regression test for https://github.com/apache/datafusion/issues/25266 +# Float interpolation must not quantize weights to six decimal places. +query RRR +SELECT + percentile_cont(arrow_cast(x, 'Float16'), arrow_cast(0.00000025, 'Float64')), Review Comment: hi @aoto-tech -- do you have time to address @kosiew 's comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
