neilconway commented on code in PR #25935: URL: https://github.com/apache/datafusion/pull/25935#discussion_r4156977135
########## Cargo.toml: ########## @@ -273,6 +273,7 @@ wildcard_dependencies = "warn" # Pedantic lints we opt out of, with the number of hits at the time we enabled `pedantic`. # Some of these we should consider enabling. +assert_is_empty = "allow" # 105 hits Review Comment: The alternative is to replace all `is_empty` asserts with something like `assert_eq!(v, [] as [T; 0])`, but that doesn't seem like a very useful way to spend our time, in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
