zhangfengcdt opened a new pull request, #6494: URL: https://github.com/apache/datafusion-comet/pull/6494
## Which issue does this PR close? Closes #5306 ## Rationale for this change The native write flags use two different shapes: `spark.comet.write.<format>.*` and `spark.comet.<format>.write.*`. This PR picks `spark.comet.write.*`, which the issue leans toward and which mirrors the existing `spark.comet.scan.*` keys. ## What changes are included in this PR? | Old key | New key | | --- | --- | | `spark.comet.parquet.write.enabled` | `spark.comet.write.parquet.enabled` | | `spark.comet.iceberg.write.enabled` | `spark.comet.write.iceberg.enabled` | | `spark.comet.write.iceberg.splitOperator.enabled` | unchanged | - `CometConf`: the two keys move, and the old keys are kept with `withAlternative`. The Scala symbols are unchanged, so no call sites change. - Two user-facing messages and the user and contributor docs now name the new keys. ## How are these changes tested? Three new tests in `CometConfSuite`: - All three write flags share the `spark.comet.write.` namespace. This fails without the change. - Each old key is still read through its alias. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
