andygrove opened a new pull request, #6486: URL: https://github.com/apache/datafusion-comet/pull/6486
## Which issue does this PR close? Refs #6426 and the RC2 regression tracker #6402. Selective backport of #6456, whose source head is c5d00f76c83acb82ba67cb35edf7ce2a44c3d2f4 and is still awaiting upstream merge. ## Rationale for this change On 1.1.0-rc1, native Iceberg years/months/days/hours disagree with iceberg-java for pre-1970 timestamps exactly 999999 microseconds after a unit boundary. This can change projection and filter results silently. This draft prepares the fix for RC2 on branch-1.1. ## What changes are included in this PR? Backport the corrected temporal arithmetic, boundary unit tests and SQL projection/filter fixture from #6456. Exclude the native writer integration, its public transform helper and writer tests: the writer calculator changes from #6239 are absent on branch-1.1. Remove the fixture comment referring to that omitted writer test. No unrelated main-branch changes are included. ## How are these changes tested? On branch-1.1 base 66800830ea30cc75fddeed1b24e50d6d7ec61c57 with this patch: - `cargo test --offline -p datafusion-comet-spark-expr --lib iceberg_funcs::temporal`: 5 passed. - `cargo build --offline`: passed; native 1.1.0 library built from this worktree. - JDK 17, default Spark 4.1: `./mvnw -o -B test -Dtest=none '-Dsuites=org.apache.comet.CometSqlFileTestSuite temporal_functions_pre_epoch'`: 1 selected fixture passed, containing five native-asserted queries. - Targeted `rustfmt --check` and `git diff --check`: passed. Other Spark profiles and full Spark SQL/Iceberg shards were not run locally. Release-branch CI provides the broader matrix. Source and release base were rechecked before publication and have not moved since local validation. Keep this draft pending upstream review and backport CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
