andygrove opened a new pull request, #6469:
URL: https://github.com/apache/datafusion-comet/pull/6469

   ## Which issue does this PR close?
   
   None. It comes out of the 1.1.0 regression audit (#6399), and the 
regressions it lists are tracked in #6402.
   
   ## Rationale for this change
   
   Comet publishes a change log for each release, but no release notes. The 
upgrade guide already says that correctness fixes "appear in the release 
notes", and the audit of 1.1.0 found regressions that users should know about 
before they upgrade, along with the settings that avoid them.
   
   ## What changes are included in this PR?
   
   - A new top-level Release Notes section in `docs/source/release-notes/`, 
with an index page and a page for 1.1.0. It sits before the change log in the 
site navigation.
   - The 1.1.0 page opens with how many 1.0.0 bugs the release fixes, then 
lists the known regressions: six wrong results, one error and one performance 
regression. Each entry links its issue, names the setting that avoids it, and 
says what else that setting sends to Spark. A last entry covers #5421, which 
moves some partial aggregates back to Spark when the Comet shuffle manager 
isn't installed. That one is a deliberate trade for correctness rather than a 
regression, but it can make those jobs slower.
   - The upgrade guide's 1.1.0 section links to the release notes.
   
   If more fixes land on `branch-1.1` before the release, their entries should 
come out. #6449, for example, fixes both #6424 and #6464.
   
   The bug counts come from the audit's data. rc1 has 131 `fix:` pull requests. 
91 of them fix bugs that shipped in 1.0.0, and about 40 of those 91 fixed 
results that differed from Spark.
   
   ## How are these changes tested?
   
   Each workaround was run against its regression's reproducer on a 1.1.0-rc1 
build. Without the setting the reproducer still differs from Spark, and with it 
the result matches Spark. The Iceberg entry was checked with Iceberg 1.11.0, 
both as a direct function call and in a filter rewritten by Iceberg's SQL 
extensions.
   
   Prettier passes on the changed files. I couldn't build the Sphinx site 
locally, and the docs job only runs on pushes to `main`, so the new section 
hasn't been rendered yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to