adriangb commented on PR #25838: URL: https://github.com/apache/datafusion/pull/25838#issuecomment-5904095666
Thanks for the in depth review! I think I addressed all points: Window and Unnest now pass through when safe (details inline), Union/Sort/Extension/Limit use `holds_outer_reference`, and comments are clarified. I kept this PR to the bug fix so it can be backported; appending correlated columns to PARTITION BY (Spark/DuckDB style, which decorrelates #25792 itself) should be a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
