github-actions[bot] commented on PR #25858: URL: https://github.com/apache/datafusion/pull/25858#issuecomment-5895837888
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 41.566s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.026s] (current) Building datafusion v55.1.0 (baseline) Built [ 41.682s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.435s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 85.567s] datafusion Building datafusion-catalog-listing v55.1.0 (current) Built [ 29.651s] (current) Parsing datafusion-catalog-listing v55.1.0 (current) Parsed [ 0.009s] (current) Building datafusion-catalog-listing v55.1.0 (baseline) Built [ 29.583s] (baseline) Parsing datafusion-catalog-listing v55.1.0 (baseline) Parsed [ 0.009s] (baseline) Checking datafusion-catalog-listing v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.058s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.381s] datafusion-catalog-listing Building datafusion-common v55.1.0 (current) Built [ 23.961s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.049s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 23.563s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.048s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.540s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 49.330s] datafusion-common Building datafusion-datasource v55.1.0 (current) Built [ 31.601s] (current) Parsing datafusion-datasource v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-datasource v55.1.0 (baseline) Built [ 31.837s] (baseline) Parsing datafusion-datasource v55.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.190s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_parameter_count_changed.ron Failed in: FileFormat::infer_schema now takes 4 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_format.rs:123 FileFormat::infer_stats now takes 5 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_format.rs:140 FileFormat::infer_ordering now takes 5 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_format.rs:160 FileFormat::infer_stats_and_ordering now takes 5 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_format.rs:181 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 64.898s] datafusion-datasource Building datafusion-datasource-arrow v55.1.0 (current) Built [ 31.864s] (current) Parsing datafusion-datasource-arrow v55.1.0 (current) Parsed [ 0.009s] (current) Building datafusion-datasource-arrow v55.1.0 (baseline) Built [ 31.468s] (baseline) Parsing datafusion-datasource-arrow v55.1.0 (baseline) Parsed [ 0.009s] (baseline) Checking datafusion-datasource-arrow v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.051s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 64.458s] datafusion-datasource-arrow Building datafusion-datasource-avro v55.1.0 (current) Built [ 30.194s] (current) Parsing datafusion-datasource-avro v55.1.0 (current) Parsed [ 0.008s] (current) Building datafusion-datasource-avro v55.1.0 (baseline) Built [ 30.321s] (baseline) Parsing datafusion-datasource-avro v55.1.0 (baseline) Parsed [ 0.008s] (baseline) Checking datafusion-datasource-avro v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.051s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 61.806s] datafusion-datasource-avro Building datafusion-datasource-csv v55.1.0 (current) Built [ 29.696s] (current) Parsing datafusion-datasource-csv v55.1.0 (current) Parsed [ 0.008s] (current) Building datafusion-datasource-csv v55.1.0 (baseline) Built [ 29.154s] (baseline) Parsing datafusion-datasource-csv v55.1.0 (baseline) Parsed [ 0.008s] (baseline) Checking datafusion-datasource-csv v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.073s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.116s] datafusion-datasource-csv Building datafusion-datasource-json v55.1.0 (current) Built [ 29.200s] (current) Parsing datafusion-datasource-json v55.1.0 (current) Parsed [ 0.009s] (current) Building datafusion-datasource-json v55.1.0 (baseline) Built [ 30.505s] (baseline) Parsing datafusion-datasource-json v55.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-json v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.066s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.804s] datafusion-datasource-json Building datafusion-datasource-parquet v55.1.0 (current) Built [ 36.353s] (current) Parsing datafusion-datasource-parquet v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-datasource-parquet v55.1.0 (baseline) Built [ 34.478s] (baseline) Parsing datafusion-datasource-parquet v55.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.103s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_datasource_parquet::CachedParquetFileReaderFactory::new takes 2 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b6fd220fad011e4a8a8a025ff535db3841d906db/datafusion/datasource-parquet/src/reader.rs:150, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/reader.rs:153 datafusion_datasource_parquet::metadata::DFParquetMetadata::with_file_metadata_cache takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b6fd220fad011e4a8a8a025ff535db3841d906db/datafusion/datasource-parquet/src/metadata.rs:202, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/metadata.rs:205 datafusion_datasource_parquet::ParquetFileReader::with_metadata_cache takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b6fd220fad011e4a8a8a025ff535db3841d906db/datafusion/datasource-parquet/src/reader.rs:243, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/reader.rs:251 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 72.122s] datafusion-datasource-parquet Building datafusion-execution v55.1.0 (current) Built [ 20.260s] (current) Parsing datafusion-execution v55.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-execution v55.1.0 (baseline) Built [ 21.022s] (baseline) Parsing datafusion-execution v55.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-execution v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.175s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field TableScopedPath.object_store_url in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/mod.rs:195 field TableScopedPath.object_store_url in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/mod.rs:195 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 42.511s] datafusion-execution ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
