bharadwaj-pendyala commented on issue #25374: URL: https://github.com/apache/datafusion/issues/25374#issuecomment-5891252750
I'd like to pick this up now that it's free. I've got a test in `datafusion/ffi/src/udaf/mod.rs` that wraps `min` through the mock foreign marker, and on main it comes back `Sensitive` instead of `Insensitive`. Plan is what you laid out: an `FFI_DistinctHandling` enum next to `FFI_AggregateOrderSensitivity`, a `distinct_handling` fn pointer on `FFI_AggregateUDF`, and the forwarding impl on `ForeignAggregateUDF`. Since `DistinctHandling` is `#[non_exhaustive]`, a variant the FFI side doesn't know yet maps to `Sensitive`, so a mismatched library can only lose the optimization, never get a wrong answer. The new field goes at the end of the struct, after `supports_null_handling_clause`, same as the last addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
