dwsmith1983 commented on PR #5613:
URL:
https://github.com/apache/datafusion-comet/pull/5613#issuecomment-5891271589
> Could that comment be updated in this PR so the two don't contradict each
other?
Updated in ac0a691. The rule stays and the reason is now the true one:
`reserved()` takes the pool's own lock, and the registry must never wait on a
pool, since `releasePlan` takes the registry lock to unregister while the
task's other plans keep reserving and releasing. The comment on the test's
probe pool no longer mentions the fair pool either.
> Could this test do the same with `Seq("org.apache.comet")`?
Yes, it listens on the package logger now, with the same note as
`CometPluginsSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
