andygrove commented on PR #6281: URL: https://github.com/apache/datafusion-comet/pull/6281#issuecomment-5876700817
This is a light fully automated review since there are so many PRs open. `benchmarks/micro/run.py` discovers every benchmark object in `spark/src/test/scala/org/apache/spark/sql/benchmark/` (`discover_suites`, `run.py:469`) and launches each one as `-Dexec.mainClass=org.apache.spark.sql.benchmark.<name>` (`suite_command`, `run.py:545`). `CometStringWriterBenchmark` sits in that directory but declares `package org.apache.spark.sql.comet.execution.arrow` (`spark/src/test/scala/org/apache/spark/sql/benchmark/CometStringWriterBenchmark.scala:20`). So a default `run.py run` will pick it up and fail it with a `ClassNotFoundException` for `org.apache.spark.sql.benchmark.CometStringWriterBenchmark`. Naming the real class in a `--suites` file doesn't get around it either, because `load_suites` keeps only the simple name and `suite_command` puts the fixed package back on. `CometArrowWriterBenchmark` in the same directory already has this problem. Could this file move to `spark/src/test/scala/org/apache/spark/sql/comet/execution/arrow/` next to `CometStringWriter Suite`? The `make benchmark-...` command in the docstring would still work, and the runner would stop picking it up. If you'd rather have it in the runner's results, would it make sense to have `discover_suites` read each file's `package` line and pass the full class name to `suite_command`? That would fix `CometArrowWriterBenchmark` at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
