andygrove commented on PR #5841: URL: https://github.com/apache/datafusion-comet/pull/5841#issuecomment-5876467963
This is a light fully automated review since there are so many PRs open. I found three comments outside the changed files that still describe the pre-split layout, so they go stale once this lands. `.scalafix-syntactic.conf:20` sends readers to the `scalafix-syntactic` job in `pr_build_linux.yml`, and `.github/workflows/pr_benchmark_check.yml:75` points at `pr_build_linux.yml` for the same semanticdb exclusion in the main lint matrix. Both `scalafix-syntactic` and `lint-java` now live in `pr_build_linux_checks.yml`. `dev/ci/linux-test-profiles.py:26` says the `lint` job runs the script and publishes the matrix that `linux-test` reads. At this head that is `prepare-matrix` in `pr_build_linux.yml`, and `lint` only runs `cargo fmt` in the checks workflow. Could these three pointers be updated in this PR, so the next person chasing a syntactic scalafix failure or editing the profile rows lands in the right file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
