comphead commented on code in PR #6346:
URL: https://github.com/apache/datafusion-comet/pull/6346#discussion_r4125885317
##########
spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java:
##########
@@ -71,17 +71,24 @@ public long acquireMemory(long size) {
}
long acquired = internal.acquireExecutionMemory(size,
nativeMemoryConsumer);
long newUsed = used.addAndGet(acquired);
- if (acquired < size) {
- logger.warn(
+ // A partial grant is routine, not an error: the native pool either
refuses the reservation,
Review Comment:
I feel this comment can be simplified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
