Kimahriman commented on code in PR #865:
URL: https://github.com/apache/datafusion-comet/pull/865#discussion_r1731811122
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2002,10 +2002,21 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
Seq(true, false).foreach { dictionaryEnabled =>
withTempDir { dir =>
val path = new Path(dir.toURI.toString, "test.parquet")
- makeParquetFileAllTypes(path, dictionaryEnabled = dictionaryEnabled,
10000)
+ makeParquetFileAllTypes(path, dictionaryEnabled = dictionaryEnabled,
1000)
Review Comment:
I had to scroll up really far while debugging the empty string vs null issue
which dumped all 10k records to the terminal 😂 happy to change it back, not
sure how much it matters to do 10k rows or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
