alamb commented on code in PR #25756:
URL: https://github.com/apache/datafusion/pull/25756#discussion_r4107213329
##########
AGENTS.md:
##########
@@ -38,7 +39,10 @@ When creating a PR, you MUST follow the [PR
template](.github/pull_request_templ
## Testing
-If documentation files changed then run
+When adding tests, you MUST follow
Review Comment:
try to prod agents along
##########
docs/source/contributor-guide/pr_review.md:
##########
@@ -133,7 +133,8 @@ Guidelines for evaluating tests:
1. Prefer `sqllogictest` (`.slt`) tests or DataFrame API tests where
possible, as they exercise **user-visible behavior** and are less coupled
- to internal implementation details than unit tests.
+ to internal implementation details than unit tests (see
Review Comment:
we already documented that end user APIs were preferred, but it was somewhat
buried
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
