andygrove commented on code in PR #805:
URL: https://github.com/apache/datafusion-comet/pull/805#discussion_r1731419091
##########
docs/source/user-guide/expressions.md:
##########
@@ -182,6 +182,14 @@ The following Spark expressions are currently available.
Any known compatibility
| VariancePop | |
| VarianceSamp | |
+## Complex Types
+
+| Expression | Notes |
+| ----------------- | --------------------------------- |
+| CreateNamedStruct | Create a struct |
+| GetElementAt | Access a field in a struct |
+| StructsToJson | Convert a struct to a JSON string |
+
Review Comment:
Good point. I have removed these comments.
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1210,6 +1210,58 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
None
}
+ case StructsToJson(options, child, timezoneId) =>
+ if (options.nonEmpty) {
+ withInfo(expr, "StructsToJson with options is not supported")
+ None
+ } else {
+
+ def isSupportedType(dt: DataType): Boolean = {
+ dt match {
+ case StructType(fields) =>
+ fields.forall(f => isSupportedType(f.dataType))
+ case DataTypes.BooleanType | DataTypes.ByteType |
DataTypes.ShortType |
+ DataTypes.IntegerType | DataTypes.LongType |
DataTypes.FloatType |
+ DataTypes.DoubleType | DataTypes.StringType =>
+ true
+ case DataTypes.DateType | DataTypes.TimestampType =>
+ // TODO implement these types with tests for formatting
options and timezone
+ false
+ case _ => false
+ }
+ }
+
+ val isSupported = child.dataType match {
+ case s: StructType =>
+ s.fields.forall(f => isSupportedType(f.dataType))
+ case _ =>
Review Comment:
I added comments for map/array support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
