findepi commented on code in PR #12166:
URL: https://github.com/apache/datafusion/pull/12166#discussion_r1731227824
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1157,10 +1157,8 @@ impl LogicalPlan {
Ok(if let LogicalPlan::Prepare(prepare_lp) = plan_with_values {
param_values.verify(&prepare_lp.data_types)?;
// try and take ownership of the input if is not shared, clone
otherwise
- match Arc::try_unwrap(prepare_lp.input) {
- Ok(input) => input,
- Err(arc_input) => arc_input.as_ref().clone(),
- }
+ Arc::try_unwrap(prepare_lp.input)
+ .unwrap_or_else(|arc_input| arc_input.as_ref().clone())
Review Comment:
moved out to https://github.com/apache/datafusion/pull/12173 so that the
code changes remain aligned with the PR title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
