alamb opened a new issue, #12156:
URL: https://github.com/apache/datafusion/issues/12156

   ### Is your feature request related to a problem or challenge?
   
   @theirix added a very nice API in  
https://github.com/apache/datafusion/pull/12151 to simplify RuntimeEnv 
construction.
   
   However, @comphead pointed out 
https://github.com/apache/datafusion/pull/12151/files#r1730134993  the names 
are now somewhat strange that you get a `runtime_env` when creating a 
`RuntimeConfig` object
   
   ```rust
               let runtime_env = RuntimeConfig::new()
                   .with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size)))
                   .build();
   ```
   
   
   
   ### Describe the solution you'd like
   
   I think a more standard pattern would be of `RuntimeConfig` was called 
`RuntimeEnvBuilder`
   
   Then the example would look like 
   
   ```rust
               let runtime_env = RuntimeEnvBuilder::new()
                   .with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size)))
                   .build();
   ```
   
   ### Describe alternatives you've considered
   
   I suggest:
   1. Rename `RuntimeEnvBuilder` to  `RuntimeConfig` 
   2. Leave a type alias `type RuntimeConfig = RuntimeEnvBuilder` to ease 
upgrades (maybe the typedef could be deprecated with a message to use 
RuntimeEnvBuilder)
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to