andygrove commented on PR #5466: URL: https://github.com/apache/datafusion-comet/pull/5466#issuecomment-5804789141
Thanks @peterxcli for finding this and working out how `MemoryReservation::try_grow` orders its size update. That analysis is what showed the removed comment was wrong. #5847 builds on your change. It keeps the per-consumer share, adds the pool-total cap from the review here, charges sibling reservations against their consumer's share, and reports the finite limit. So I'm closing this as superseded. The underlying bug is tracked in #5961. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
