timsaucer commented on PR #25009: URL: https://github.com/apache/datafusion/pull/25009#issuecomment-5794024710
> Yes I see. I am mostly asking tim if the condition I am concerned about which is for serialization and deserilization is it typically good practice in this repo to have all nodes be able to deserialize without any dependency to children nodes. I was under the assumption that this was the case but here it causes us to have to serialize more over the wire then we would need to in some cases so we may not actually want to if not needed. In my opinion, the litmus test is this: For any given variation, does serialization + deserialization produce an identical result? Second to that, can either approach demonstrably do this faithful reproduction with a smaller byte footprint? I haven't gone through and considered all of the permutations of this, but I think you do want to do a little testing around metadata at different levels and demonstrate the faithful reproduction. Does that answer the question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
