Toby1009 commented on PR #25498: URL: https://github.com/apache/datafusion/pull/25498#issuecomment-5779664390
LGTM! I also checked underflow through both the scalar and array paths locally. One optional test suggestion: could we add a `TimestampSecond(i64::MIN)` / `minute` case using `date_trunc_scalar_and_array`, asserting that both return an error? The existing `scalar_fine_granularity_rejects_underflow` test calls `general_date_trunc` directly, so it doesn't exercise the new scalar fast path. Non-blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
