tshauck commented on code in PR #12138:
URL: https://github.com/apache/datafusion/pull/12138#discussion_r1729485111
##########
datafusion/functions/src/string/common.rs:
##########
@@ -214,6 +214,23 @@ where
i64,
_,
>(array, op)?)),
+ DataType::Utf8View => {
+ let string_array = as_string_view_array(array)?;
Review Comment:
Not sure happy with this implementation, but it seems to work. I tried
something akin to:
```rust
let result = string_array.iter().map(|string| string.map(op));
```
but that seems to require a clone of `op` which isn't allowed based on the
existing function definition, and seems worth avoiding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
