pepijnve commented on code in PR #25404:
URL: https://github.com/apache/datafusion/pull/25404#discussion_r4060774886
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3129,12 +3134,18 @@ pub struct TableScan {
pub filters: Vec<Expr>,
/// Optional number of rows to read
pub fetch: Option<usize>,
+ /// Optional number of rows to skip
+ pub offset: Option<usize>,
/// Statistics the planner would like the provider to answer for this
/// scan, typically attached by a custom optimizer rule from the
/// surrounding plan (e.g. Min/Max for sort keys).
///
/// A [`BTreeSet`], not a `Vec` to keep the resulting plan deterministic.
- pub statistics_requests: BTreeSet<StatisticsRequest>,
+ ///
+ /// Boxed to keep this rarely-populated field from growing every
+ /// `TableScan` (and thus `LogicalPlan`) by its own size; see
+ /// `test_size_of_logical_plan`.
+ pub statistics_requests: Box<BTreeSet<StatisticsRequest>>,
Review Comment:
verified that this is covered by an upgrade note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
