haohuaijin commented on code in PR #25227:
URL: https://github.com/apache/datafusion/pull/25227#discussion_r4052709163
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -260,6 +263,8 @@ impl CastExpr {
(Int8, Int16 | Int32 | Int64)
| (Int16, Int32 | Int64)
| (Int32, Int64)
+ | (Int32, Date32)
Review Comment:
> these are lossless because they have the same underlying representation?
yes
> Should we also have entries for Date64 and Int64?
added, we can also extend this helper in a follow-up to recognize more safe
conversions, such as `UInt32` → `Int64` that i mention in
https://github.com/apache/datafusion/pull/25227#discussion_r3999343833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
