ShayanGho commented on code in PR #25181:
URL: https://github.com/apache/datafusion/pull/25181#discussion_r4052198552
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1684,6 +1684,63 @@ async fn simple_window_function() -> Result<()> {
roundtrip("SELECT RANK() OVER (PARTITION BY a ORDER BY b), d, sum(b) OVER
(PARTITION BY a) FROM data;").await
}
+#[tokio::test]
+async fn stacked_windows_with_same_default_name_via_builder() -> Result<()> {
Review Comment:
Good catch, done in the latest commit. The builder test now orders both
row_number windows by a, filters a > 1 between them, and asserts the
round-tripped values against the original plan (rn1 = 2, rn2 = 1). I also
confirmed it fails if the consumer references the inherited window column
instead of the new alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
