sunchao commented on code in PR #6021:
URL: https://github.com/apache/datafusion-comet/pull/6021#discussion_r4051136378
##########
.github/workflows/docs.yaml:
##########
@@ -49,6 +49,17 @@ jobs:
java-version: '17'
cache: 'maven'
+ - name: Setup Node
+ uses: actions/setup-node@v7
+ with:
+ node-version: '24'
+
+ - name: Install mermaid-cli
+ # Draws the ```mermaid fences into SVG at build time. Without mmdc on
PATH the build
+ # still succeeds but silently drops every diagram, so it is installed
unconditionally.
+ # See mermaid_output_format in docs/source/conf.py for why the browser
cannot draw them.
+ run: npm install -g @mermaid-js/[email protected]
Review Comment:
### Correctness
[P2] Confirmed in the post-merge docs deployment
The [Build docs
job](https://github.com/apache/datafusion-comet/actions/runs/35399385876/job/105776132397)
checked out merge commit `5705a58ac2ef7e6b2674c87f3b495f789ebfcc8d`. All three
Mermaid renders failed with `No usable sandbox!` at 22:08 UTC. Sphinx then
reported `build succeeded, 61 warnings`, and the `Copy & push the generated
HTML` step completed successfully.
This confirms the browser-launch failure in the actual deployment
environment, rather than only the source-supported expectation in my original
comment. Please configure a sandbox-compatible browser launch and require the
three diagrams to render successfully before publishing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
