advitrocks9 commented on PR #24827: URL: https://github.com/apache/datafusion/pull/24827#issuecomment-5722941733
Both are fixed. For nullability I overrode `return_field_from_args` since the default marks the field nullable. I also pinned the schema with `datafusion.explain.show_schema` instead of `EXPLAIN VERBOSE` so the optimizer pass list does not get copied into the file. For signed zero this was not specific to `equal_null`. `[0.0] = [-0.0]` was also false on main. I fixed it in `compare_op_for_nested` by making `normalize_float_zero` recurse into nested children. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
