CuteChuanChuan commented on issue #25332:
URL: https://github.com/apache/datafusion/issues/25332#issuecomment-5698649451
Hi @jayzhan211 , thanks for taking a look!
Agreed. `Start` and `AtRow { row: 0 }` would describe the same position, so
keeping `Start` brings back the duplicate encoding this change is meant to
remove. I'll drop it and go with two variants:
```rust
enum ProbeOffset {
AtRow { row: usize },
MidChain { row: usize, next: u64 },
}
```
The first-chunk check then becomes `offset == ProbeOffset::AtRow { row: 0 }`,
and I'll document on the type that a returned offset is never
`AtRow { row: 0 }`, since `HashJoinStream::process_probe_batch` relies on
that.
I'll open a PR for this. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
