dwsmith1983 commented on PR #5654: URL: https://github.com/apache/datafusion-comet/pull/5654#issuecomment-5682552374
> **Fix:** preserve root first-wins behavior in footer validation while retaining nested rejection. Add a mixed ID/name regression through the reader factory. Done. `validate_field_mapping` now renames every later exact duplicate at the root to a name no request can match, keeping its type and metadata, before resolving, so the footer check binds the first root column the way the adapter does while a requested nested duplicate is still refused. Two regressions: a unit test on the check itself with `d`, `d`, `a(id=7)` requested by name and by id under case sensitivity and field ids (passes), the same under case-insensitivity (Spark's ambiguity error) and the nested shape (refused); and a reader-factory test that writes that file, loads its footer and runs `FieldIdCheck.validate` on it. Both fail without the change. Merged with `main` at a8e8157ea first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
