mohammadnaqvi04 commented on PR #25008: URL: https://github.com/apache/datafusion/pull/25008#issuecomment-5686379569
I took a look at potentially splitting this PR into two more contained ones between `EXISTS`/`NOT EXISTS`, and then a stacked `IN`/`NOT IN` on top, to reduce some of the surface area here. The reason I'm holding off on doing so, for now at least, is because the non-injective correlation bug, from your last failing example query, appears in both of the aforementioned shape categories. I'm going to stress test a bit more, and I can refactor for better composability afterward. On a secondary note, to make this a bit more robust, I'm working on extending our [fuzz test setup](https://github.com/apache/datafusion/tree/main/datafusion/core/tests/fuzz_cases) to generate random query shapes for groupless aggregates. I'll cross-verify against other engines to see where this breaks, and hopefully iterate from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
