kosiew commented on code in PR #25255:
URL: https://github.com/apache/datafusion/pull/25255#discussion_r4014171228
##########
datafusion/core/tests/physical_optimizer/filter_pushdown.rs:
##########
@@ -1754,6 +1754,589 @@ fn
test_hashjoin_parent_filter_pushdown_semi_anti_join() {
assert_parent_filter_remains(plan);
Review Comment:
Could we add a small `NullEqualsNull` inner-join regression that includes
NULL keys? The transfer should be sound in this mode as well, but the new tests
currently only cover `NullEqualsNothing`. Having a test here would help protect
the nullable-key case and make that behavior explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
