andygrove commented on PR #5930: URL: https://github.com/apache/datafusion-comet/pull/5930#issuecomment-5671799120
Merged `main` to clear a conflict with #5885. The conflict itself was small — that PR removed `spark_3_4` from `SPARK_OPT_IN` and added `SPARK_DEPRECATED` in the same list-shaped hunk this branch touches to add `build_linux_full` to `PR_TIER`, so the resolution is just both. The more useful thing the merge turned up is that #5885 documents the push tier in `docs/source/contributor-guide/ci.md`, which I had missed — my original diff only updated `.github/workflows/README.md`. That guide said the Linux build "also runs on push so that the dependency caches on main stay fresh" with no mention that it is now cache-writers-only, which would have left the contributor-facing docs describing the old behaviour. I have added the cache-refresh-only paragraph there and a line about the new invariant in the "Changing CI itself" section. Same file also gets the guidance a contributor actually needs: if you add a job to `pr_build_linux.yml`, give it the guard unless it writes a cache main needs, and the config check will tell you if you forget. I re-ran the four mutation cases after the merge rather than assuming they survived it, plus a fifth for #5885's own invariant (putting `spark_3_4` back in the queue), and re-checked the per-event routing table. All still hold. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
