alexandrefimov commented on issue #25100: URL: https://github.com/apache/datafusion/issues/25100#issuecomment-5660217114
Part of this exists already, for plans DataFusion reads. [`consumer_integration.rs`](https://github.com/apache/datafusion/blob/c2cf28940b1eb15e640393fecd51f69a9990d64c/datafusion/substrait/tests/cases/consumer_integration.rs) compares the logical plans DataFusion builds from 22 TPC-H plans taken from [substrait-io/consumer-testing](https://github.com/substrait-io/consumer-testing) with snapshots, and [`logical_plans.rs`](https://github.com/apache/datafusion/blob/c2cf28940b1eb15e640393fecd51f69a9990d64c/datafusion/substrait/tests/cases/logical_plans.rs) does the same for five plans generated by substrait-java's Isthmus. Both read JSON files committed here, the TPC-H ones last refreshed in 2024, so a change in substrait-java never reaches them. #25049 (`output_type`), #25190 (`CASE`) and this issue (`phase`) are about plans DataFusion writes and substrait-java reads, and neither suite covers that. DataFusion's Substrait tests do not run substrait-java, and consumer-testing runs DataFusion as a producer, but [its consumers](https://github.com/substrait-io/consumer-testing/tree/197b62c22f1f8a21333a99033f7c84257df7bbce/substrait_consumer/consumers) are Acero, DataFusion and DuckDB. Until #11545 is fixed, substrait-java rejects any DataFusion plan that calls a function before it reads `output_type` or `phase`, so a test in that direction has to work around #11545 first, as [the table in #25090](https://github.com/apache/datafusion/pull/25090#issuecomment-5638196686) does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
