andygrove opened a new pull request, #5926:
URL: https://github.com/apache/datafusion-comet/pull/5926

   ## Which issue does this PR close?
   
   No issue. Follow-up to #5843 and #5871, which moved the other heavy suites 
behind the merge queue.
   
   ## Rationale for this change
   
   `delta_build_gate.yml` and `pyarrow_udf_test.yml` predate the merge queue 
and still carry their own `push: main` and `pull_request` triggers, so every 
merge runs them twice: once in the queue and again on push to main. Everything 
else in CI already routes through `ci.yml`, where the queue is the 
authoritative gate and heavy jobs have no `push` tier.
   
   ## What changes are included in this PR?
   
   - Convert both workflows to `workflow_call` reusables invoked from `ci.yml`, 
and drop their own triggers and concurrency groups. The umbrella owns both now.
   - Add `delta_gate` and `pyarrow_udf` entries to `FILTERS` and `POLICY` in 
`dev/ci/compute-changes.py`. Both are queue-only with an opt-in label, 
`run-delta-build-gate` and `run-pyarrow-udf-tests`, the same shape as the 
benchmark compile check.
   - The PyArrow path list is the one the old workflow declared. The Delta gate 
filter is narrower than its old `paths-ignore`: main sources, poms, 
`contrib/delta/**` and the gate script. The script inspects the cargo tree, 
effective pom, compiled classes and dylib symbols, so test files cannot change 
its verdict.
   - Add both jobs to `required_checks.needs` so a failure still blocks the 
merge.
   - Extend `dev/ci/check-ci-config.py` with routing spot checks and 
event-policy cases for the two jobs, including the `mvnw` and `.mvn/**` inputs 
they both consume.
   - Update `.github/workflows/README.md` and the contributor CI guide.
   
   The two opt-in labels do not exist in the repository yet and need to be 
created before they can be applied. Until then the jobs run in the queue only, 
which is the intended default.
   
   ## How are these changes tested?
   
   - `python3 dev/ci/check-ci-config.py` passes with the new cases.
   - `dev/ci/compute-changes.py` run by hand for `push`, `merge_group`, and a 
`labeled` event with `run-delta-build-gate`: push routes only `build_linux`, 
the queue routes both new jobs, and the label routes only `delta_gate`.
   - `actionlint` on the three touched workflow files.
   - `prettier --check` on the two Markdown files.
   - The merge queue run for this PR exercises both jobs, since it touches 
`ci.yml`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to