haohuaijin commented on PR #25259: URL: https://github.com/apache/datafusion/pull/25259#issuecomment-5666028897
Thanks for you review @jayzhan211 , i apply all suggestion in [93e08cb](https://github.com/apache/datafusion/pull/25259/commits/93e08cbe019049ad879cee50fe2c799884ce660a) (keep the old name-based mapping for `from_child_with_allowed_indices`). > It seems this PR might solve the issue I just open #25296 yes, this pr fix #25296, i add #25296's reproduce test case to .slt in [6d0e2b1](https://github.com/apache/datafusion/pull/25259/commits/6d0e2b186b0b9bb0b65b2dc2c24abb8dbd3803dd) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
