dwsmith1983 commented on PR #5864: URL: https://github.com/apache/datafusion-comet/pull/5864#issuecomment-5665548852
> Could that query go away and the note about null intervals move up to the sentinel, here and in `date_add_interval_ansi_spark35.sql`? Done in both, and the `CAST(NULL AS ...)` columns in the four all-literal queries are gone too since `NullPropagation` folds them the same way; the table rows keep the null coverage. > the three points I left on 12 September that have not had a reply yet All three are in. The `+` and `-` notes now say a date plus or minus a DAY-precision day-time interval is rewritten to `DateAdd` over `ExtractANSIIntervalDays`, which has no serde and falls back. Every fixture's lead query carries an `expect_dispatch(...)` sentinel; `timestamp_add_interval.sql` pins `make_dt_interval` because the root is `TimeAdd` through 4.0 and `TimestampAddInterval` from 4.1, and the builder is only dispatched as part of that kernel. `CometSubtractDates` has the comment on `subtractDates` writing microseconds 0. The datetime fixtures pass on 3.5 and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
