AdamGS commented on code in PR #25273: URL: https://github.com/apache/datafusion/pull/25273#discussion_r4005115818
########## datafusion/expr/src/utils.rs: ########## @@ -1427,6 +1427,10 @@ pub fn add_filter(plan: LogicalPlan, predicates: &[&Expr]) -> Result<LogicalPlan /// # Return value /// /// Tuple of (expressions containing joins, remaining non-join expressions) +#[deprecated( Review Comment: This function strips outer references which I think is somewhat unexpected, and was the root cause of this bug. Its not called anymore, so deprecating it seems like a nice improvement, reducing the overall API surface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
