edubraqd commented on code in PR #24916:
URL: https://github.com/apache/datafusion/pull/24916#discussion_r4004968883
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1099,7 +1099,9 @@ fn coerce_frame_bound(
}
}
-fn extract_window_frame_target_type(col_type: &DataType) -> Result<DataType> {
+/// The type that RANGE frame offsets are coerced to for an ORDER BY column of
+/// `col_type`, or `None` if the type does not support RANGE frames.
Review Comment:
Done in b3f0806. `check_free_range_order_by_types` now rejects lists of
nested elements (`List<Struct>`, `List<List<..>>`, also under
Dictionary/RunEndEncoded), so `ORDER BY d, l` stops at planning as it did on
`main`. The mixed test expects the planning error, and I added the `ORDER BY d,
list_of_primitives` case to show that one still works. The direct
`List<Struct>` cases are unchanged, for the comparator follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
