alamb opened a new pull request, #25278:
URL: https://github.com/apache/datafusion/pull/25278

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion-sqlparser-rs/issues/2453
   
   ## Rationale for this change
   
   `sqlparser` [0.63.0 has been 
released](https://crates.io/crates/sqlparser/0.63.0) 
([changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/changelog/0.63.0.md)),
 so update DataFusion to use it.
   
   This PR is based on the testing PR #24926, which ran DataFusion's CI against 
the `release-0.63.0` branch ahead of the release. The only difference is that 
the `sqlparser` dependency now points at the released crates.io version instead 
of a git pin.
   
   ## What changes are included in this PR?
   
   1. Update `sqlparser` to 0.63.0
   2. Update DataFusion for upstream AST changes, including:
      - `OrderByOptions::asc: Option<bool>` is now `OrderByOptions::sort: 
Option<OrderBySort>` (adds `ORDER BY ... USING <op>`, which DataFusion rejects 
with a `not_impl_err`)
      - `LIKE`/`ILIKE`/`SIMILAR TO` escape chars are now `Option<Box<Expr>>` 
instead of `Option<ValueWithSpan>`
      - `Expr::Cast` no longer has an `array` field
      - `SELECT INTO` now supports multiple targets (`SelectInto::targets`); 
DataFusion rejects anything other than a single table name
      - New AST variants handled with `not_impl_err`/`plan_err`: 
`FunctionArgumentClause::Where`, `MergeUpdateKind::Wildcard`, 
`MergeInsertKind::Wildcard`, `MergeAction::DoNothing`, 
`TableConstraint::Exclude`, new `CREATE TABLE` options (`UNLOGGED`, `WITH 
CONNECTION`, `MULTISET`, `FALLBACK`, `WITH DATA`)
      - New struct fields on constraints (`include`, `no_inherit`) and 
`DataType::Map`
   
   ## Are these changes tested?
   
   Yes, by existing CI (including sqllogictests). #24926 ran the same code 
changes against the pre-release `sqlparser`.
   
   ## Are there any user-facing changes?
   
   Updated `sqlparser` version. Error messages for a few unsupported syntax 
cases have changed slightly (see updated test in 
`datafusion/sql/tests/cases/params.rs`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to