athlcode opened a new issue, #5893: URL: https://github.com/apache/datafusion-comet/issues/5893
After #5876, `-Pstrict-warnings` passes on the Scala 2.12 profiles and CI enforces it for Spark 3.5. The Scala 2.13 profiles still fail. `./mvnw test-compile -Pspark-4.0 -Pstrict-warnings` reported 100 warnings at the time #5876 was opened (83 main, 17 test), nearly all in categories 2.12 does not raise: - `-Xlint:nonlocal-return` (42): a `return` inside a closure, which the compiler implements by throwing. 17 are in `CometIcebergNativeWrite.scala`. - Non-exhaustive matches (20). - 2.13 collection deprecations (11): `JavaConverters`, `Stream`, `MapOps.retain`. - A handful of widenings, shadowed names and inferred `Any`/`Object`. These were left out of #5876 because the first two need control-flow changes rather than annotations. Done when `./mvnw test-compile -Pspark-4.0 -Pstrict-warnings -DskipTests` passes and the `strict-scala-warnings` CI job also covers a 2.13 profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
