TinyMurky commented on code in PR #25158:
URL: https://github.com/apache/datafusion/pull/25158#discussion_r3995665652
##########
datafusion/physical-plan/src/aggregates/single_stream.rs:
##########
@@ -104,6 +104,10 @@ pub(crate) struct SingleHashAggregateStream {
/// Tracks the high-level stream lifecycle. The hash table owns the
lower-level
/// state for emitting output batches.
state: Option<SingleHashAggregateState>,
+
+ /// When set, there are no aggregate expressions: AggregateExec routes
+ /// limited non-DISTINCT aggregates to a different stream.
Review Comment:
I changed the comment of `group_values_soft_limit` to
https://github.com/TinyMurky/datafusion/blob/e92aee75ea5bf774d0dbd6be648849a124c7797e/datafusion/physical-plan/src/aggregates/single_stream.rs#L136-L138
##########
datafusion/physical-plan/src/aggregates/single_stream.rs:
##########
@@ -104,6 +104,10 @@ pub(crate) struct SingleHashAggregateStream {
/// Tracks the high-level stream lifecycle. The hash table owns the
lower-level
/// state for emitting output batches.
state: Option<SingleHashAggregateState>,
+
+ /// When set, there are no aggregate expressions: AggregateExec routes
+ /// limited non-DISTINCT aggregates to a different stream.
Review Comment:
I changed the comment of `group_values_soft_limit` to
https://github.com/apache/datafusion/blob/e92aee75ea5bf774d0dbd6be648849a124c7797e/datafusion/physical-plan/src/aggregates/single_stream.rs#L136-L138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
