dwsmith1983 commented on issue #4485: URL: https://github.com/apache/datafusion-comet/issues/4485#issuecomment-5637000596
Since #4538 (c0c8c9529) `width_bucket` goes through a registered serde: `CometWidthBucket` in spark/src/main/scala/org/apache/comet/serde/math.scala is in `QueryPlanSerde.mathExpressions`, so it gets the `getSupportLevel` hooks, the per-expression enable/allowIncompatible configs, and it now shows up in docs/source/user-guide/latest/expressions.md. The only remnant is that the spark-3.5 and spark-4.x `CometExprShim` still return the same `classOf[WidthBucket] -> CometWidthBucket` entry from `sparkVersionSpecificMathExpressions`; it is merged into the same map with the same value, so it is a no-op and can be dropped in any passing cleanup rather than its own issue. Suggest closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
