neilconway commented on code in PR #25140: URL: https://github.com/apache/datafusion/pull/25140#discussion_r3993813350
########## datafusion/sqllogictest/test_files/datetime/date_part.slt: ########## @@ -1859,3 +1859,42 @@ logical_plan physical_plan 01)FilterExec: c@0 >= 2024-01-01 AND c@0 < 2025-01-01 02)--DataSourceExec: partitions=1, partition_sizes=[1] + Review Comment: Might also be useful to have a test case for the timezone variant (e.g., Lima in 1994). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
