dwsmith1983 commented on issue #5069: URL: https://github.com/apache/datafusion-comet/issues/5069#issuecomment-5637253553
#5136 (671a8dd9e) made this change: `cast_floating_point_to_decimal128` in native/spark-expr/src/conversion_funcs/numeric.rs now treats NaN and +/-Infinity as NULL in every eval mode, including ANSI, and only finite values that overflow the target precision raise `NUMERIC_VALUE_OUT_OF_RANGE`. The test this issue pointed at was inverted and renamed to `test_cast_float_to_decimal_ansi_nan_and_infinity_are_null`. Suggest closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
