ump45nose opened a new pull request, #1730: URL: https://github.com/apache/datafusion-python/pull/1730
# Which issue does this PR close? Part of #1728. # Rationale for this change Issue #1728 documents two example-side problems. The self-contained `csv-read-options.py` fix is already covered by #1729; this PR addresses the other half: nine top-level examples (`export.py`, `import.py`, `python-udaf.py`, `python-udf.py`, `query-pyarrow-data.py`, `sql-to-pandas.py`, `sql-using-python-udaf.py`, `sql-using-python-udf.py`, `substrait.py`) end in bare `assert`s and print nothing, so running them gives a reader no output and a silent script is indistinguishable from a broken one. # What changes are included in this PR? - Each of the nine examples now ends with a terminal `df.show()` or `print(...)` showing its final result; the existing asserts are kept unchanged. - No workflow or CI changes are included — the missing CI job from the issue is being designed in #1717. - No file overlaps with #1717 or #1729. # Are there any user-facing changes? No API changes. The examples are documentation; after this change they visibly print their results when run. Testing: ran all nine scripts with the released `datafusion` 54.0.0 wheel on Python 3.12 (macOS ARM). `sql-to-pandas.py` was additionally verified end-to-end with the NYC taxi parquet documented in `examples/README.md` (generated `chart.png` removed afterwards). `ruff check` / `ruff format` (v0.15.1 as pinned in `.pre-commit-config.yaml`) and `codespell` pass on the changed files. Prepared with AI assistance (agent contribution). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
