namanjain24-sudo commented on PR #25191:
URL: https://github.com/apache/datafusion/pull/25191#issuecomment-5635147792
@gabotechs @kosiew when you have a moment, would one of you be able to
trigger the workflows on this PR? The contributor guide notes a committer has
to do that for a new contributor, and no checks have run here yet.
Locally this passes `cargo test -p datafusion-substrait` (272 tests), `cargo
xtask ci step test substrait`, and the `rust_clippy.sh`, `rust_fmt.sh`,
`typos_check.sh` and `rust_docs.sh` steps of the lint suite.
On the change itself: the one judgement call is desugaring `CASE <base> WHEN
<value>` into `<base> = <value>` conditions rather than emitting
`SwitchExpression`. I went that way because `SwitchExpression.IfValue.if` is a
`Literal`, so it cannot express a non-literal WHEN operand, and our consumer
currently answers `not_impl_err!("Switch expression not supported")`, so
emitting it would break our own round trip. The trade-off is that the base
expression is now repeated once per WHEN arm. I described both in #25190 and
would be glad to take the PR in a different direction if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
