SubhamSinghal commented on code in PR #21621:
URL: https://github.com/apache/datafusion/pull/21621#discussion_r3986868249
##########
datafusion/optimizer/src/push_down_limit.rs:
##########
@@ -47,146 +50,159 @@ impl OptimizerRule for PushDownLimit {
true
}
- #[expect(clippy::only_used_in_recursion)]
fn rewrite(
&self,
plan: LogicalPlan,
config: &dyn OptimizerConfig,
) -> Result<Transformed<LogicalPlan>> {
- let LogicalPlan::Limit(mut limit) = plan else {
- return Ok(Transformed::no(plan));
- };
+ match plan {
+ LogicalPlan::Limit(limit) => rewrite_limit(limit, config),
+ LogicalPlan::Sort(s) if s.fetch.is_some() => {
Review Comment:
Added doc in
https://github.com/apache/datafusion/commit/8dbc1dd53034ec22e39c20a515f54f1addf60cc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
